Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct CLI plutus testing #2900

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Direct CLI plutus testing #2900

merged 3 commits into from
Jul 12, 2021

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jul 6, 2021

This introduces a test Plutus transaction test which does not use an intervening test. Doing this directly from Haskell allows us more flexibility to make assertions.

@newhoggy newhoggy force-pushed the direct-plutus-testing branch 4 times, most recently from 98b5a96 to 5753ef6 Compare July 7, 2021 05:48
@newhoggy newhoggy marked this pull request as ready for review July 7, 2021 05:48
@newhoggy newhoggy changed the title Direct plutus testing Direct CLI plutus testing Jul 7, 2021
@@ -101,8 +101,6 @@ test-suite cardano-testnet-tests
, hedgehog
, hedgehog-extras
, filepath
, lens
, lens-aeson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Good work! A few comments.

cardano-testnet/test/Spec/Extras.hs Outdated Show resolved Hide resolved

-- Querying UTxO at $dummyaddress. If there is ADA at the address the Plutus script successfully executed!

result <- T.pack <$> H.execCli' execConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 7, 2021

All comments addressed. Merging.

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 7, 2021

bors merge

iohk-bors bot added a commit that referenced this pull request Jul 7, 2021
2900: Direct CLI plutus testing r=newhoggy a=newhoggy

This introduces a test Plutus transaction test which does not use an intervening test.  Doing this directly from Haskell allows us more flexibility to make assertions.

Co-authored-by: John Ky <john.ky@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 7, 2021

Build failed:

@newhoggy newhoggy force-pushed the direct-plutus-testing branch 2 times, most recently from 5149b4b to 0151f86 Compare July 8, 2021 04:36
@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 8, 2021

bors merge

iohk-bors bot added a commit that referenced this pull request Jul 8, 2021
2900: Direct CLI plutus testing r=newhoggy a=newhoggy

This introduces a test Plutus transaction test which does not use an intervening test.  Doing this directly from Haskell allows us more flexibility to make assertions.

Co-authored-by: John Ky <john.ky@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 8, 2021

Build failed:

Comment on lines +88 to +84
let plutusRequiredSpace = id @Integer 70000000
let plutusRequiredTime = id @Integer 70000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not (700000 :: Integer ) ?

Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 8, 2021

bors merge

iohk-bors bot added a commit that referenced this pull request Jul 8, 2021
2900: Direct CLI plutus testing r=newhoggy a=newhoggy

This introduces a test Plutus transaction test which does not use an intervening test.  Doing this directly from Haskell allows us more flexibility to make assertions.

Co-authored-by: John Ky <john.ky@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 8, 2021

Build failed:

@newhoggy newhoggy force-pushed the direct-plutus-testing branch 6 times, most recently from e136b51 to 1d70176 Compare July 11, 2021 23:05
@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 12, 2021

@iohk-bors iohk-bors bot merged commit f3ef4ed into master Jul 12, 2021
@iohk-bors iohk-bors bot deleted the direct-plutus-testing branch July 12, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants